Implement RFC-0232: FIDL bindings for multiple API levels [42085274]

Project

Status Update

No update yet.

Description

mk...@google.com

created issue #1

Oct 24, 2023 10:52PM

See the Implementation section of the RFC.

Comments

is...@google.com <is...@google.com> #2Oct 24, 2023 10:52PM

This issue was migrated from

crbug.com/fuchsia/135677?no_tracker_redirect=1

[Monorail components added to Monorail Components custom field.]

ap...@google.com <ap...@google.com> #3Feb 26, 2024 06:50PM

Project: fuchsia
Branch: main

commit 741f089b0573b088dba04223a8b65028e9c034cc
Author: Mitchell Kember <mkember@google.com>
Date: Mon Feb 26 18:47:56 2024

[fuchsia.sys2] Drop legacy support for StartResult

This removes `legacy=true` on the StartResult enum, which was removed in
I05811cdd39bacd6776e9fe95f65032af191f6d1a. It is no longer available in
any supported API level.

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: I551f6d0e0985aaab824ef5289babf170ff7af96e
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/996692
Reviewed-by: Hunter Freyer <hjfreyer@google.com>
API-Review: Hunter Freyer <hjfreyer@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>

M sdk/fidl/fuchsia.sys2/lifecycle_controller.fidl

https://fuchsia-review.googlesource.com/996692

ap...@google.com <ap...@google.com> #4Feb 26, 2024 07:15PM

Project: fuchsia
Branch: main

commit e882965d1e2bd4fe3058c7d98f11ce51b8b16928
Author: Mitchell Kember <mkember@google.com>
Date: Mon Feb 26 19:12:22 2024

[fuchsia.settings.policy] Drop legacy support for VolumePolicyController

This removes `legacy=true` on the VolumePolicyController protocol, which
was removed in I7c9628c549ac3bb902883e131b7e3198aea02810. It is no
longer available in any supported API level.

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: I648ee1030cbf3f77b20309f44217a1b787390c66
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/996532
Commit-Queue: Mitchell Kember <mkember@google.com>
API-Review: Hunter Freyer <hjfreyer@google.com>
Reviewed-by: Hunter Freyer <hjfreyer@google.com>
Reviewed-by: Chip Fukuhara <cfukuhara@google.com>

M sdk/fidl/fuchsia.settings.policy/fuchsia.settings.policy.api
M sdk/fidl/fuchsia.settings.policy/volume_policy.fidl
M src/settings/service/src/tests/

service_configuration_tests.rs

https://fuchsia-review.googlesource.com/996532

ap...@google.com <ap...@google.com> #5Feb 27, 2024 06:44PM

Project: fuchsia
Branch: main

commit a472dd2d2c063d0af87f9ee1c6cdb88deeb80361
Author: Mitchell Kember <mkember@google.com>
Date: Tue Feb 27 18:42:12 2024

[fuchsia.component.config] Add legacy=true

This adds legacy=true on the fuchsia.component.config library, which was
removed in API level 14, because it still exists in a supported API
level (12).

This library was removed in If825f4535a43d1c5fa59a60cd63aac5764100aa4
without legacy=true.

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: I892c72b88e3113ae32006ab0c827fdc1b84457b7
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/997856
Reviewed-by: Ian McKellar <ianloic@google.com>
Reviewed-by: David Gilhooley <dgilhooley@google.com>
Commit-Queue: Mitchell Kember <mkember@google.com>
API-Review: Ian McKellar <ianloic@google.com>

M sdk/fidl/fuchsia.component.config/fuchsia.component.config.api
M sdk/fidl/fuchsia.component.config/overview.fidl

https://fuchsia-review.googlesource.com/997856

ap...@google.com <ap...@google.com> #6Feb 27, 2024 08:28PM

Project: fuchsia
Branch: main

commit 4a2ceeb2491d81bdab44a8e2fa3549eab01e5d32
Author: Mitchell Kember <mkember@google.com>
Date: Tue Feb 27 20:26:52 2024

[fuchsia.gpu.magma] Add legacy=true

This adds legacy=true to ObjectType.EVENT and Primary.ImportObject2,
which were removed in API level 17, because they still exist in
supported API levels (the oldest supported level is currently 12).

These elements were removed in Ia1e1ab786a30cca6e8dca44a41df2feae09f1ec6
without legacy=true. Rather than restore the original ImportObject2
implementation, I made it return an error.

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: I036fbf3c5ec45fc83949a4df3ceb6eb948ca2dbd
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/997719
Reviewed-by: Craig Stout <cstout@google.com>
API-Review: Ian McKellar <ianloic@google.com>
Reviewed-by: Ian McKellar <ianloic@google.com>
Commit-Queue: Mitchell Kember <mkember@google.com>

M sdk/fidl/fuchsia.gpu.magma/fuchsia.gpu.magma.api
M sdk/fidl/fuchsia.gpu.magma/magma.fidl
M src/graphics/magma/lib/magma_service/sys_driver/primary_fidl_server.cc
M src/graphics/magma/lib/magma_service/sys_driver/primary_fidl_server.h

https://fuchsia-review.googlesource.com/997719

ap...@google.com <ap...@google.com> #7Feb 27, 2024 09:46PM

Project: fuchsia
Branch: main

commit 8091e7ea15621e4ebfc2d7399c4edbfebc12cf65
Author: Mitchell Kember <mkember@google.com>
Date: Tue Feb 27 21:43:52 2024

[fuchsia.lowpan.device] Remove Identity.xpanid_deprecated

This removes the xpanid_deprecated table field, since it only existed to
support API levels 10 and below, and we have since retired those levels.

If1fa8d2f74d1e0be2ca5f0deabbc0930e37a2ef8 changed xpanid from a vector
an array (at a new ordinal), and added xpanid_deprecated so that the
platform could continue supporting the old vector.

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: I970945ea856980b8180a82c1195eb0bbae37d8c7
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/996282
Reviewed-by: Sundarajan Srinivasan <sundarsrini@google.com>
Reviewed-by: Hunter Freyer <hjfreyer@google.com>
API-Review: Hunter Freyer <hjfreyer@google.com>
API-Review: Bruno Dal Bo <brunodalbo@google.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Reviewed-by: Bruno Dal Bo <brunodalbo@google.com>
Reviewed-by: Jiaming (Charlie) Wang <jiamingw@google.com>

M sdk/fidl/fuchsia.lowpan.device/device.fidl
M sdk/fidl/fuchsia.lowpan.device/fuchsia.lowpan.device.api
M src/connectivity/lowpan/drivers/lowpan-ot-driver/src/driver/

convert.rs
M src/connectivity/lowpan/drivers/lowpan-ot-driver/src/driver/

tests.rs
M src/connectivity/lowpan/lib/lowpan_driver_common/src/

dummy_device.rs
M src/connectivity/lowpan/tools/lowpanctl/src/

form_command.rs
M src/connectivity/lowpan/tools/lowpanctl/src/

join_command.rs
M src/connectivity/lowpan/tools/lowpanctl/src/

provision_command.rs

https://fuchsia-review.googlesource.com/996282

ap...@google.com <ap...@google.com> #8Feb 27, 2024 10:13PM

Project: fuchsia
Branch: main

commit 93f0605a77c97c59be9c03c2f0ec8945c833c49b
Author: Mitchell Kember <mkember@google.com>
Date: Tue Feb 27 22:12:05 2024

[build][fidl] Improve --available override mechanism

This makes fidl GN template's `available` parameter have full control
over the --available fidlc option. Previously, it would append the
fuchsia target API level even when `available` was provided. This CL
also asserts that `available` is only used on testonly libraries, since
it is easy to misuse and end up with inconsistent bindings.

The motivation for this is that while implementing RFC-0232, I found
some spurious errors in example libraries using fake fuchsia versions,
and wanted to override --available to avoid those errors.

Bug: 42085274
Change-Id: I4fb8c6f4b13fe7b78f85488c4ffa92fa65e292cc
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/996163
Reviewed-by: Hunter Freyer <hjfreyer@google.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
Reviewed-by: Ian McKellar <ianloic@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Commit-Queue: Mitchell Kember <mkember@google.com>

M build/fidl/fidl.gni
M build/fidl/fidl_ir.gni
M build/fidl/fidl_library.gni
M examples/fidl/fuchsia.examples.docs/BUILD.gn
M tools/fidl/fidlc/goldens/versions.json.golden
M tools/fidl/fidlc/testdata/BUILD.gn

https://fuchsia-review.googlesource.com/996163

ap...@google.com <ap...@google.com> #9Feb 28, 2024 12:12AM

Project: fuchsia
Branch: main

commit 27737417a5a4388eb63cfbd3b844959ae8bdf628
Author: Mitchell Kember <mkember@google.com>
Date: Wed Feb 28 00:09:50 2024

[fuchsia.diagnostics] Add legacy=true

This adds legacy=true on the fuchsia.diagnostics/LogSettings method
RegisterInterest because it is removed=18, so it still exists in
supported API levels (the oldest supported level is currently 12).

This method was removed in I22d047d9981b33d63f2ebfe9629bebb8862efa74
without legacy=true.

There are two implementations of the LogSettings server. I changed them
to handle RegisterInterest as follows:

* src/developer/ffx/plugins/log/src/

testing_utils.rs:
Panic, since it's test code.
* src/diagnostics/archivist/src/logs/servers/

log_settings.rs:
Log a warning and close the channel.

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: Ifbf0aee9126ea1aae0f4e61558640e7240bab1b0
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/997718
Commit-Queue: Mitchell Kember <mkember@google.com>
API-Review: Ian McKellar <ianloic@google.com>
Reviewed-by: Ian McKellar <ianloic@google.com>
API-Review: Miguel Flores <miguelfrde@google.com>
Reviewed-by: Miguel Flores <miguelfrde@google.com>

M sdk/fidl/fuchsia.diagnostics/fuchsia.diagnostics.api
M sdk/fidl/fuchsia.diagnostics/log_settings.fidl
M src/developer/ffx/plugins/log/src/

testing_utils.rs
M src/diagnostics/archivist/src/logs/servers/

log_settings.rs

https://fuchsia-review.googlesource.com/997718

ap...@google.com <ap...@google.com> #10Feb 28, 2024 10:26PM

Project: fuchsia
Branch: main

commit c960a740fcacfada912108174515b7f681df167d
Author: Mitchell Kember <mkember@google.com>
Date: Wed Feb 28 22:25:18 2024

[fuchsia.component.decl] Add legacy=true

This adds legacy=true on fuchsia.component.decl declarations removed in
API levels 13, 14 and 15, because they still exist in a supported API
level (12).

These elements were removed in the these CLs without legacy=true:

* I52cf055ca1a471bd81a4013e023a4edae6cade3f
* I334599d6588e956598b70c1ef1fd3d8dcfe35207
* I46779dbbb3375d0b46e7a551e54f792cbbca6918

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: I247e2b8542f380dd8aed08a12dbd75f7c7f775a7
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/997717
Reviewed-by: Gary Bressler <geb@google.com>
Reviewed-by: Miguel Flores <miguelfrde@google.com>
Commit-Queue: Mitchell Kember <mkember@google.com>
API-Review: Gary Bressler <geb@google.com>

M sdk/fidl/fuchsia.component.decl/capability.fidl
M sdk/fidl/fuchsia.component.decl/expose.fidl
M sdk/fidl/fuchsia.component.decl/fuchsia.component.decl.api
M sdk/fidl/fuchsia.component.decl/offer.fidl
M sdk/fidl/fuchsia.component.decl/use.fidl
M src/sys/component_manager/src/model/actions/

shutdown.rs
M src/sys/lib/cm_rust/src/

lib.rs
M src/sys/lib/cm_types/src/

lib.rs

https://fuchsia-review.googlesource.com/997717

ap...@google.com <ap...@google.com> #11Mar 14, 2024 08:43PM

Project: fuchsia
Branch: main

commit feca38c23853a1e423a878f13c9d6374e34f98d1
Author: Mitchell Kember <mkember@google.com>
Date: Thu Mar 14 20:39:29 2024

[fuchsia.images] Add legacy=true

This adds legacy=true on fuchsia.images declarations removed at API
level 14, because they still exist in a supported API level (12).

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: Ife612860f291869c6427d81e601e03217e4e65a1
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1008316
Reviewed-by: Clayton Wilkinson <wilkinsonclay@google.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
API-Review: Clayton Wilkinson <wilkinsonclay@google.com>
Commit-Queue: Mitchell Kember <mkember@google.com>

M sdk/fidl/fuchsia.images/encoded_image.fidl
M sdk/fidl/fuchsia.images/fuchsia.images.api

https://fuchsia-review.googlesource.com/1008316

ap...@google.com <ap...@google.com> #12Mar 14, 2024 08:49PM

Project: fuchsia
Branch: main

commit 26a88e816d9fcb60177a3286e6f83287d5dd5b86
Author: Mitchell Kember <mkember@google.com>
Date: Thu Mar 14 20:47:29 2024

[fuchsia.images2] Add legacy=true

This adds legacy=true on fuchsia.images2 declarations removed at API
level 18, because they still exist in supported API levels (the oldest
supported level is currently 12).

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: I005a42a2f6aeacab4c7619a39cb0680bc621cf5d
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1008317
Commit-Queue: Mitchell Kember <mkember@google.com>
Reviewed-by: Clayton Wilkinson <wilkinsonclay@google.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
API-Review: Clayton Wilkinson <wilkinsonclay@google.com>

M sdk/fidl/fuchsia.images2/math.fidl

https://fuchsia-review.googlesource.com/1008317

ap...@google.com <ap...@google.com> #13Mar 14, 2024 09:21PM

Project: fuchsia
Branch: main

commit dd2a871d471874132d578c622cfeabb0bd18900c
Author: Sarah Chan <spqchan@google.com>
Date: Thu Mar 14 21:17:50 2024

Revert "[fuchsia.images2] Add legacy=true"

This reverts commit 26a88e816d9fcb60177a3286e6f83287d5dd5b86.

Reason for revert: Causing build failures from mismatch golden files

Original change's description:
> [fuchsia.images2] Add legacy=true
>
> This adds legacy=true on fuchsia.images2 declarations removed at API
> level 18, because they still exist in supported API levels (the oldest
> supported level is currently 12).
>
> The motivation for this is to line up legacy=true with the current set
> of supported API levels for the implementation of RFC-0232.
>
> Bug: 42085274
> Change-Id: I005a42a2f6aeacab4c7619a39cb0680bc621cf5d
> Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1008317
> Commit-Queue: Mitchell Kember <mkember@google.com>
> Reviewed-by: Clayton Wilkinson <wilkinsonclay@google.com>
> Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
> API-Review: Clayton Wilkinson <wilkinsonclay@google.com>

Bug: 42085274
Change-Id: Ibbd44cf688477db9f46952b45f0265588cc25547
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1008497
Reviewed-by: Mitchell Kember <mkember@google.com>
Commit-Queue: Sarah Chan <spqchan@google.com>
Reviewed-by: RubberStamper 🤖 <android-build-ayeaye@system.gserviceaccount.com>

M sdk/fidl/fuchsia.images2/math.fidl

https://fuchsia-review.googlesource.com/1008497

ap...@google.com <ap...@google.com> #14Mar 15, 2024 05:10PM

Project: fuchsia
Branch: main

commit bfe97478d631d1c8e6735978ced1d4abd18a251b
Author: Mitchell Kember <mkember@google.com>
Date: Fri Mar 15 17:09:35 2024

Reland "[fuchsia.images2] Add legacy=true"

This is a reland of commit 26a88e816d9fcb60177a3286e6f83287d5dd5b86

This time it includes the .api file change.

Original change's description:
> [fuchsia.images2] Add legacy=true
>
> This adds legacy=true on fuchsia.images2 declarations removed at API
> level 18, because they still exist in supported API levels (the oldest
> supported level is currently 12).
>
> The motivation for this is to line up legacy=true with the current set
> of supported API levels for the implementation of RFC-0232.
>
> Bug: 42085274
> Change-Id: I005a42a2f6aeacab4c7619a39cb0680bc621cf5d
> Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1008317
> Commit-Queue: Mitchell Kember <mkember@google.com>
> Reviewed-by: Clayton Wilkinson <wilkinsonclay@google.com>
> Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
> API-Review: Clayton Wilkinson <wilkinsonclay@google.com>

Bug: 42085274, 329693879, 329730193
Change-Id: Ic56e3c6993fb47f2e5feab43664620af66d6314d
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1009072
API-Review: Clayton Wilkinson <wilkinsonclay@google.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
Reviewed-by: Clayton Wilkinson <wilkinsonclay@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>

M sdk/fidl/fuchsia.images2/fuchsia.images2.api
M sdk/fidl/fuchsia.images2/math.fidl

https://fuchsia-review.googlesource.com/1009072

ap...@google.com <ap...@google.com> #15Mar 15, 2024 05:54PM

Project: fuchsia
Branch: main

commit 257c73cde939cdac3f56e435e716edade5200ba8
Author: Mitchell Kember <mkember@google.com>
Date: Fri Mar 15 17:52:50 2024

[fuchsia.ui] Add legacy=true

This adds legacy=true on fuchsia.ui.{gfx,input,policy.scenic}
declarations removed in API levels 13 and 14, because they still exist
in supported API levels (the oldest supported level is currently 12).

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: I74adadcb5eacd851f2b85b8bf0b9ee541cbac16e
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1009092
Reviewed-by: Clayton Wilkinson <wilkinsonclay@google.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
API-Review: Clayton Wilkinson <wilkinsonclay@google.com>
Commit-Queue: Mitchell Kember <mkember@google.com>

M sdk/fidl/fuchsia.ui.gfx/fuchsia.ui.gfx.api
M sdk/fidl/fuchsia.ui.gfx/pose_buffer_provider.fidl
M sdk/fidl/fuchsia.ui.input/fuchsia.ui.input.api
M sdk/fidl/fuchsia.ui.input/input_device_registry.fidl
M sdk/fidl/fuchsia.ui.input/input_event_constants.fidl
M sdk/fidl/fuchsia.ui.policy/fuchsia.ui.policy.api
M sdk/fidl/fuchsia.ui.policy/presentation.fidl
M sdk/fidl/fuchsia.ui.policy/presenter.fidl
M sdk/fidl/fuchsia.ui.scenic/fuchsia.ui.scenic.api
M sdk/fidl/fuchsia.ui.scenic/snapshot.fidl

https://fuchsia-review.googlesource.com/1009092

ap...@google.com <ap...@google.com> #16Mar 15, 2024 07:29PM

Project: fuchsia
Branch: main

commit fc481955e98d411c2da4d89e891e3c112d5c071b
Author: Mitchell Kember <mkember@google.com>
Date: Fri Mar 15 19:26:48 2024

[fuchsia.mediastreams] Add legacy=true

This adds legacy=true on fuchsia.mediastreams declarations removed at
HEAD, because they still exist in supported API levels.

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: Ib9e82aedb846256ee98035be9689e31937aef115
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1006891
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
API-Review: Clayton Wilkinson <wilkinsonclay@google.com>
Reviewed-by: Clayton Wilkinson <wilkinsonclay@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>

M sdk/fidl/fuchsia.mediastreams/compression.fidl
M sdk/fidl/fuchsia.mediastreams/fuchsia.mediastreams.api
M sdk/fidl/fuchsia.mediastreams/media_format.fidl
M sdk/fidl/fuchsia.mediastreams/video_format.fidl

https://fuchsia-review.googlesource.com/1006891

ap...@google.com <ap...@google.com> #17Mar 15, 2024 07:50PM

Project: fuchsia
Branch: main

commit a9cbddf7918a1f23d93b21312027f8a85f0a0f24
Author: Mitchell Kember <mkember@google.com>
Date: Fri Mar 15 19:48:49 2024

[fuchsia.wlan.common] Add legacy=true

This adds legacy=true on fuchsia.wlan.common declarations removed in API
level 13, because they still exist in a supported API level (12).

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: If77da86f93b63063f8849edbb049e0e28a6119fc
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1008272
Commit-Queue: Mitchell Kember <mkember@google.com>
Reviewed-by: Clayton Wilkinson <wilkinsonclay@google.com>
API-Review: Clayton Wilkinson <wilkinsonclay@google.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>

M sdk/fidl/fuchsia.wlan.common/fuchsia.wlan.common.api
M sdk/fidl/fuchsia.wlan.common/history.fidl

https://fuchsia-review.googlesource.com/1008272

ap...@google.com <ap...@google.com> #18Mar 15, 2024 09:21PM

Project: fuchsia
Branch: main

commit 450068424bd54c1bf0a1c43799db1a7096e40693
Author: Mitchell Kember <mkember@google.com>
Date: Fri Mar 15 21:18:45 2024

[fidl] Add legacy=true to fuchsia.{lightsensor,modular,sys}

This adds legacy=true on declarations removed at API levels 13, 14, and
HEAD because they still exist in supported API levels (currently the
oldest supported level is 12) in the following libraries:

* fuchsia.lightsensor
* fuchsia.modular
* fuchsia.sys
* fuchsia.sys.test

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: I3bd7ee2ae2bb1a16958f3bbc36493641af294b60
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1008936
Reviewed-by: Clayton Wilkinson <wilkinsonclay@google.com>
Commit-Queue: Mitchell Kember <mkember@google.com>
API-Review: Clayton Wilkinson <wilkinsonclay@google.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>

M sdk/fidl/fuchsia.lightsensor/calibrator.fidl
M sdk/fidl/fuchsia.lightsensor/fuchsia.lightsensor.api
M sdk/fidl/fuchsia.lightsensor/types.fidl
M sdk/fidl/fuchsia.modular/fuchsia.modular.api
M sdk/fidl/fuchsia.modular/overview.fidl
M sdk/fidl/fuchsia.sys.test/BUILD.gn
M sdk/fidl/fuchsia.sys.test/cache.fidl
M sdk/fidl/fuchsia.sys.test/fuchsia.sys.test.api
M sdk/fidl/fuchsia.sys/fuchsia.sys.api
M sdk/fidl/fuchsia.sys/overview.fidl

https://fuchsia-review.googlesource.com/1008936

ap...@google.com <ap...@google.com> #19Mar 21, 2024 02:56AM

Project: fuchsia
Branch: main

commit d23a1425fabd3cdb9f08a2c20ac6ecd74b350974
Author: Mitchell Kember <mkember@google.com>
Date: Thu Mar 21 02:53:18 2024

[fidl] Add legacy=true in fuchsia.media

This adds legacy=true on declarations removed at API level 15 in
fuchsia.media because they still exist in supported API levels (the
oldest supported level is currently 12).

These declarations were removed in without legacy=true in
I9531a6056a7bfb9aa7d42c204d1840ba50305a8f and
I8f914345e727862685dad7038034a6210ab30dbf.

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: I0bc4e3a112ecd5fde9fa0f8d75acd20e28e8dc6e
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1011052
Commit-Queue: Mitchell Kember <mkember@google.com>
API-Review: Clayton Wilkinson <wilkinsonclay@google.com>
Reviewed-by: Dale Sather <dalesat@google.com>
Reviewed-by: Tim Kilbourn <tkilbourn@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Reviewed-by: Clayton Wilkinson <wilkinsonclay@google.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>

M sdk/fidl/fuchsia.media/audio.fidl
M sdk/fidl/fuchsia.media/audio_core.fidl
M sdk/fidl/fuchsia.media/audio_device_enumerator.fidl
M sdk/fidl/fuchsia.media/fuchsia.media.api
M src/media/audio/audio_core/v1/audio_core_impl.h
M src/media/audio/audio_core/v1/audio_device_manager.cc
M src/media/audio/audio_core/v1/audio_device_manager.h
M src/media/audio/audio_core/v1/audio_impl.h
M src/media/audio/audio_core/v2/audio_core_server.h
M src/media/audio/audio_core/v2/audio_server.cc
M src/media/audio/audio_core/v2/audio_server.h
M src/media/audio/consumer/test/fake_audio_core.h
M src/media/audio/drivers/tests/audio_device_enumerator_stub.cc
M src/media/audio/drivers/tests/audio_device_enumerator_stub.h
M src/media/sounds/soundplayer/test/soundplayer_tests.cc
M src/virtualization/bin/vmm/device/tests/virtio_sound_test.cc

https://fuchsia-review.googlesource.com/1011052

ap...@google.com <ap...@google.com> #20Mar 23, 2024 12:24AM

Project: fuchsia
Branch: main

commit 5f586d67af087ab4f63a6178813982ed528c4675
Author: Mitchell Kember <mkember@google.com>
Date: Sat Mar 23 00:21:58 2024

[

fuchsia.io] Add legacy=true on inotify APIs

This adds legacy=true on

fuchsia.io declarations related to inotify
removed at API level 13, because they still exist in a supported API
level (the current oldest supported API level is 12).

The inotify declarations were removed without legacy=true in
I272ba060239398f223b554aef8b8f08d338a9ec4.

I had to delete

fuchsia.io/Directory2.AddInotifyFilter rather than
adding legacy=true because it had implementations in VFS, which is
compiled both in tree and out of tree, and there is no mechanism to
support that in C++. See

https://fxbug.dev/330426357 for details.
This is safe to do because inotify was never fully implemented or used.

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274, 330426357
Change-Id: Ib2d50967d89d48f5a3ce21bee99cfa93bd8de197
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1009215
Reviewed-by: Chris Suter <csuter@google.com>
Reviewed-by: Hunter Freyer <hjfreyer@google.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
Reviewed-by: Clayton Wilkinson <wilkinsonclay@google.com>
Reviewed-by: David Dorwin <ddorwin@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
API-Review: Clayton Wilkinson <wilkinsonclay@google.com>

M sdk/fidl/

fuchsia.io/directory2.fidl
M sdk/fidl/

fuchsia.io/fuchsia.io.api
M sdk/fidl/

fuchsia.io/inotify.fidl
M sdk/history/12/fuchsia.io.api_summary.json
M src/storage/lib/vfs/cpp/directory_connection.h

https://fuchsia-review.googlesource.com/1009215

ap...@google.com <ap...@google.com> #21Mar 23, 2024 01:29AM

[Details redacted due to bug visibility]

Change-Id: I0ed844c3004c81ec578d21f76756e3d16dc99d69

https://turquoise-internal-review.googlesource.com/822590

ap...@google.com <ap...@google.com> #22Mar 23, 2024 04:24AM

Project: fuchsia
Branch: main

commit cca4a0201a3fb770d65efed3d28f983aec54e44c
Author: Mitchell Kember <mkember@google.com>
Date: Sat Mar 23 04:22:13 2024

[fuchsia.hardware.radar] Add legacy=true

This adds legacy=true on fuchsia.hardware.radar declarations removed at
API level 14, since they still exist in supported API levels (the
current oldest supported API level is 12).

The GetBurstSize method was removed without legacy=true in
I3813389cf94bfe3a60a967fbd06992e8070da100.

The OnBurst2 event was removed without legacy=true in
If1a0de1c1de1155fcd8da4cf4097237c30c4527b.

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: Ia026b606f5319574b61e93def79e0fb1d5b744ca
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1013133
API-Review: Ian McKellar <ianloic@google.com>
Reviewed-by: Braden Kell <bradenkell@google.com>
Commit-Queue: Mitchell Kember <mkember@google.com>
Reviewed-by: Ian McKellar <ianloic@google.com>

M sdk/fidl/fuchsia.hardware.radar/fuchsia.hardware.radar.api
M sdk/fidl/fuchsia.hardware.radar/radar.fidl
M src/devices/radar/bin/radar-proxy/reader-instance.cc
M src/devices/radar/bin/radar-proxy/reader-instance.h
M src/devices/radar/bin/radar-proxy/test/radar-proxy-test.h
M src/devices/radar/bin/radarutil/radarutil-test.cc
M src/devices/radar/lib/vmo-manager/vmo-manager.h

https://fuchsia-review.googlesource.com/1013133

ap...@google.com <ap...@google.com> #23Mar 25, 2024 10:40PM

[Details redacted due to bug visibility]

Change-Id: I5397a050d86b274baef0846ca168f0ccbdfeedf5

https://turquoise-internal-review.googlesource.com/823950

ap...@google.com <ap...@google.com> #24Mar 25, 2024 11:47PM

Project: fuchsia
Branch: main

commit 73313dd90f5261680c3f29461223277d087bf999
Author: Mitchell Kember <mkember@google.com>
Date: Mon Mar 25 23:43:40 2024

[fidl] Add legacy=true in fuchsia.{settings,sysmem}

This adds legacy=true on declarations removed at HEAD in
fuchsia.settings and fuchsia.sysmem because they still exist in
supported API levels.

The method fuchsia.settings/Display.WatchLightSensor was removed without
legacy=true in Ideb0c0785afc31b649089238de38cbc869db1df8.

The fuchsia.sysmem AuxBuffer related APIs were removed from without
legacy=true in I857c7686942358ba6a5e1ea14135fd532dff5988.

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: Ic510e943cd5f067c0ea64c89e31bbfc5f532aad3
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1009216
API-Review: Clayton Wilkinson <wilkinsonclay@google.com>
Reviewed-by: Clayton Wilkinson <wilkinsonclay@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
Reviewed-by: Dustin Green <dustingreen@google.com>

M sdk/fidl/fuchsia.settings/display.fidl
M sdk/fidl/fuchsia.settings/fuchsia.settings.api
M sdk/fidl/fuchsia.sysmem/collection.fidl
M sdk/fidl/fuchsia.sysmem/constraints.fidl
M sdk/fidl/fuchsia.sysmem/driver_connector.fidl
M sdk/fidl/fuchsia.sysmem/fuchsia.sysmem.api
M src/developer/ffx/plugins/setui/display/src/

get.rs
M src/developer/ffx/plugins/setui/display/src/

lib.rs
M src/developer/ffx/plugins/setui/display/src/

set.rs
M src/developer/ffx/plugins/setui/display/src/

watch.rs
M src/devices/sysmem/drivers/sysmem/buffer_collection.cc
M src/devices/sysmem/drivers/sysmem/buffer_collection.h

https://fuchsia-review.googlesource.com/1009216

ap...@google.com <ap...@google.com> #25Mar 26, 2024 12:32AM

Project: fuchsia
Branch: main

commit 14210d3611491a2494ab8454086f0154efaf08ff
Author: Mitchell Kember <mkember@google.com>
Date: Tue Mar 26 00:30:31 2024

[fuchsia.hardware.radar] Complete GetBurstSize soft transition

This removes #define FUCHSIA_HARDWARE_RADAR_IMPLEMENT_GET_BURST_SIZE,
completing the soft transition for vendor repos that was started in
Ia026b606f5319574b61e93def79e0fb1d5b744ca.

Bug: 42085274
Change-Id: I85623de462871c19c4ac1d4ef6dd496661976368
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1014602
Reviewed-by: Braden Kell <bradenkell@google.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
Commit-Queue: Mitchell Kember <mkember@google.com>

M src/devices/radar/lib/vmo-manager/vmo-manager.h

https://fuchsia-review.googlesource.com/1014602

ap...@google.com <ap...@google.com> #26Apr 22, 2024 06:58PM

Project: fuchsia
Branch: main

commit e6b72936c34c64186fd24f3996335125abe2f9b9
Author: Mitchell Kember <mkember@google.com>
Date: Mon Apr 22 18:56:08 2024

[fidlc] Add more versioning replacement tests

This adds more tests to versioning_replacement_tests.cc. This is in
preparation for an upcoming change that will move the removed/replaced
validation from AvailabilityStep to its own step after CompileStep.

There are also some cleanups and small changes to the other versioning
test files, such as using V1, V2 etc. consts instead of Version::From,
and avoiding `replaced` with different decl kinds, which may become an
error in the future.

This also makes @available(replaced=N) on `compose` an error, reusing
fi-0204. Replacing compositions does not make sense, and it was causing
problems with the upcoming refactor.

Test: fx test fidlc-test
Bug: 42085274, 330775608
Change-Id: I933cf4fd129182f0364f9768cd191d9ae9239955
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1030835
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Reviewed-by: Ian McKellar <ianloic@google.com>

M docs/reference/fidl/language/error-catalog/_fi-0204.md
M tools/fidl/fidlc/src/availability_step.cc
M tools/fidl/fidlc/src/diagnostics.h
M tools/fidl/fidlc/tests/versioning_attribute_tests.cc
M tools/fidl/fidlc/tests/versioning_basic_tests.cc
M tools/fidl/fidlc/tests/versioning_inheritance_tests.cc
M tools/fidl/fidlc/tests/versioning_overlap_tests.cc
M tools/fidl/fidlc/tests/versioning_platform_tests.cc
M tools/fidl/fidlc/tests/versioning_replacement_tests.cc

https://fuchsia-review.googlesource.com/1030835

ap...@google.com <ap...@google.com> #27Apr 23, 2024 10:00PM

Project: fuchsia
Branch: main

commit 9f2a45626f604469b5d50cc0f0e8c662a02ddc83
Author: Mitchell Kember <mkember@google.com>
Date: Tue Apr 23 21:58:28 2024

[fidlc] Add ReplacementStep

This moves @available removed/replaced validation from AvailabilityStep
into its own step, ReplacementStep. The order of steps is now:

Consume -> Availability -> Resolve -> Compile -> Replacement -> ...

This is needed for two upcoming changes to removed/replaced validation:

*

https://fxbug.dev/330775608: Consider all protocol methods, not just
the non-composed methods.

*

https://fxbug.dev/335716034: Check that replacements have the same
ordinal, not just the same name.

I will fix those in follow-ups since they require changing attributes in
some SDK libraries at the same time.

This also makes it an error to replace a member at the same version that
its enclosing declaration is removed/replaced. Before, this caused an
error later in compilation. Now the error is more consistent with other
validation as can be seen in the versioning_inheritance_tests.cc change.

Test: fx test fidlc-test
Bug: 42085274, 330775608, 335716034
Change-Id: I26c02c14a0f18bf86549471312c28d9a5001f552
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1024054
Commit-Queue: Mitchell Kember <mkember@google.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
Reviewed-by: Ian McKellar <ianloic@google.com>

M tools/fidl/fidlc/BUILD.gn
M tools/fidl/fidlc/src/availability_step.cc
M tools/fidl/fidlc/src/compile_step.cc
M tools/fidl/fidlc/src/compiler.cc
M tools/fidl/fidlc/src/flat_ast.h
A tools/fidl/fidlc/src/replacement_step.cc
A tools/fidl/fidlc/src/replacement_step.h
M tools/fidl/fidlc/src/versioning_types.cc
M tools/fidl/fidlc/src/versioning_types.h
M tools/fidl/fidlc/tests/versioning_inheritance_tests.cc

https://fuchsia-review.googlesource.com/1024054

ap...@google.com <ap...@google.com> #28Apr 24, 2024 04:23AM

Project: fuchsia
Branch: main

commit eb7cbd1c15ddcc73c925634f58085a60fb1be22c
Author: Mitchell Kember <mkember@google.com>
Date: Wed Apr 24 04:21:35 2024

[fidlc] Validate removed/replaced composed methods

This changes @available(removed=N) and @available(replaced=N) validation
to consider all protocol methods. Previously, it only considered the
non-composed methods.

Composition is basically a shortcut for copying and pasting methods
(with @selector), so for compatibility purposes composed methods should
be treated just like other methods. In practice people have been moving
methods between protocols using composition, and these should be modeled
as replaced=N rather than removed=N.

This is a follow up to I26c02c14a0f18bf86549471312c28d9a5001f552 which
moved this validation into a new step so that it could have access to
composed methods set during the CompileStep.

NO_IFTTT=There are no @available attributes in src/devices/sysmem/drivers/sysmem/combined_token.fidl

Test: fx test fidlc-test
Bug: 42085274
Fixed: 330775608
Change-Id: I6224426c54c22ea40c1d5adb4d22c6c4b901bc48
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1034492
Reviewed-by: Ian McKellar <ianloic@google.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
Commit-Queue: Mitchell Kember <mkember@google.com>
API-Review: Ian McKellar <ianloic@google.com>

M sdk/fidl/

fuchsia.io/node2.fidl
M sdk/fidl/fuchsia.sysmem/collection.fidl
M sdk/fidl/fuchsia.wlan.softmac/softmac.fidl
M tools/fidl/fidlc/src/flat_ast.cc
M tools/fidl/fidlc/src/flat_ast.h
M tools/fidl/fidlc/src/replacement_step.cc
M tools/fidl/fidlc/tests/versioning_replacement_tests.cc

https://fuchsia-review.googlesource.com/1034492

ap...@google.com <ap...@google.com> #29May 3, 2024 08:54PM

Project: fuchsia
Branch: main

commit b0d7daf7b40620b78571d5fa13fd84cf7cb01ebc
Author: Mitchell Kember <mkember@google.com>
Date: Fri May 03 20:53:08 2024

[fidlc] Fix removed/replaced composed method validation

This is a follow up to I6224426c54c22ea40c1d5adb4d22c6c4b901bc48 which
extended @available(removed=N) and @available(replaced=N) validation to
composed methods. That change turned out to be incomplete, handling many
cases incorrectly. This solves it properly and adds many more tests,
such as transition from a composed method back to a non-composed one.

This reverts the change to disallow @available(replaced=N) on `compose`
statements. It is now allowed, and means all those composed methods are
replaced by new methods (either directly or from new compositions).

Some other changes:

* Move owning_protocol parent pointers from Method to MethodWithInfo.

* Store the ComposedProtocol* on MethodWithInfo instead of just a bool.

* Use Element* in removed/replaced diagnostics instead of just the name.

* Remove Checker class in ReplacementStep. It doesn't save much code,
and once we validate member ordinals (

https://fxbug.dev/335716034) it
will be even harder to share it between declarations and members.

Test: fx test fidlc-test
Bug: 42085274, 330775608
Change-Id: I362b3bb8e5feedf6ebb71b3f1b9d0164c9fd128e
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1040481
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
Reviewed-by: Ian McKellar <ianloic@google.com>
API-Review: Ian McKellar <ianloic@google.com>

M docs/reference/fidl/language/error-catalog/_fi-0204.md
M sdk/fidl/fuchsia.wlan.softmac/softmac.fidl
M tools/fidl/fidlc/src/availability_step.cc
M tools/fidl/fidlc/src/compile_step.cc
M tools/fidl/fidlc/src/compiler.cc
M tools/fidl/fidlc/src/diagnostics.h
M tools/fidl/fidlc/src/flat_ast.cc
M tools/fidl/fidlc/src/flat_ast.h
M tools/fidl/fidlc/src/json_generator.cc
M tools/fidl/fidlc/src/replacement_step.cc
M tools/fidl/fidlc/tests/versioning_attribute_tests.cc
M tools/fidl/fidlc/tests/versioning_replacement_tests.cc

https://fuchsia-review.googlesource.com/1040481

ap...@google.com <ap...@google.com> #30May 29, 2024 03:23PM

Project: fuchsia
Branch: main

commit 8672f74b7e410da3cb3dea9a8f3b72c5be29bfc3
Author: Mitchell Kember <mkember@google.com>
Date: Wed May 29 15:22:18 2024

[fidlc] Implement @available argument 'renamed'

This implements the @available argument 'renamed' from the design
document "FIDL versioning: Renaming".

The `renamed` argument can only be used on members, not declarations. It
must be used together with either `replaced` or `removed`. For example,
here is how you rename a table field:

type Foo = table {
@available(replaced=2, renamed="good_name")
1: bad_name string;
@available(added=2)
1: good_name string;
};

Here is how you remove a table field and use a different name for it
post-removal, e.g. when targeting multiple versions {1,2}:

type Foo = table {
@available(removed=2, renamed="deprecated_name")
1: name string;
};

In both cases the original name is free to be reused.

A follow-up will add ordinal validation (

https://fxbug.dev/335716034).
This will make the system much more useful since the compiler will
enforce using the correct removed/replaced/renamed combination.

Test: fx test fidlc-test
Bug: 42085274
Change-Id: Ibcf4dff225776a6ec604fa9a169f1aef52f36631
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1042482
Commit-Queue: Mitchell Kember <mkember@google.com>
API-Review: Ian McKellar <ianloic@google.com>
Reviewed-by: Ian McKellar <ianloic@google.com>

M docs/error/_redirects.yaml
M docs/reference/fidl/language/errcat.md
M docs/reference/fidl/language/error-catalog/_fi-0205.md
M docs/reference/fidl/language/error-catalog/_fi-0206.md
A docs/reference/fidl/language/error-catalog/_fi-0211.md
A docs/reference/fidl/language/error-catalog/_fi-0212.md
A docs/reference/fidl/language/error-catalog/_fi-0213.md
A docs/reference/fidl/language/error-catalog/_fi-0214.md
A docs/reference/fidl/language/error-catalog/_fi-0215.md
M docs/reference/fidl/language/error-catalog/_files.txt
M sdk/fidl/fuchsia.hardware.audio/codec.fidl
M tools/fidl/fidlc/src/attribute_schema.cc
M tools/fidl/fidlc/src/availability_step.cc
M tools/fidl/fidlc/src/diagnostics.h
M tools/fidl/fidlc/src/replacement_step.cc
M tools/fidl/fidlc/tests/errcat_good_tests.cc
A tools/fidl/fidlc/tests/fidl/bad/fi-0211.test.fidl
A tools/fidl/fidlc/tests/fidl/bad/fi-0212.test.fidl
A tools/fidl/fidlc/tests/fidl/bad/fi-0213.test.fidl
A tools/fidl/fidlc/tests/fidl/bad/fi-0214.test.fidl
A tools/fidl/fidlc/tests/fidl/bad/fi-0215.test.fidl
M tools/fidl/fidlc/tests/fidl/bad/files.txt
A tools/fidl/fidlc/tests/fidl/good/fi-0205-c.test.fidl
A tools/fidl/fidlc/tests/fidl/good/fi-0211.test.fidl
A tools/fidl/fidlc/tests/fidl/good/fi-0212-a.test.fidl
A tools/fidl/fidlc/tests/fidl/good/fi-0212-b.test.fidl
A tools/fidl/fidlc/tests/fidl/good/fi-0213-a.test.fidl
A tools/fidl/fidlc/tests/fidl/good/fi-0213-b.test.fidl
A tools/fidl/fidlc/tests/fidl/good/fi-0214-a.test.fidl
A tools/fidl/fidlc/tests/fidl/good/fi-0214-b.test.fidl
A tools/fidl/fidlc/tests/fidl/good/fi-0215.test.fidl
M tools/fidl/fidlc/tests/fidl/good/files.txt
M tools/fidl/fidlc/tests/versioning_attribute_tests.cc
M tools/fidl/fidlc/tests/versioning_replacement_tests.cc

https://fuchsia-review.googlesource.com/1042482

ap...@google.com <ap...@google.com> #31May 31, 2024 06:48PM

Project: fuchsia
Branch: main

commit 19f654f74e1c854f5cfec15090941f6f345d8079
Author: Mitchell Kember <mkember@google.com>
Date: Fri May 31 18:43:20 2024

[fuchsia.driver.test] Add legacy=true

This adds legacy=true on fuchsia.driver.test declarations removed in API
level 18, because they still exist in supported API levels (currently
the oldest supported level is 15).

These elements were removed in Id808bfcfe67a08499a45b3d36c167a6629b5ad0e
without legacy=true.

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: Ia7fa6431d362e06c5fb72b7742c1d4faf59af928
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1057553
Reviewed-by: Christopher Johnson <crjohns@google.com>
API-Review: Christopher Johnson <crjohns@google.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
Commit-Queue: Mitchell Kember <mkember@google.com>

M sdk/fidl/fuchsia.driver.test/fuchsia.driver.test.api
M sdk/fidl/fuchsia.driver.test/realm.fidl

https://fuchsia-review.googlesource.com/1057553

ap...@google.com <ap...@google.com> #32May 31, 2024 06:52PM

Project: fuchsia
Branch: main

commit c278583a6cf775d5ef5877b690e876f2cc0cf35c
Author: Mitchell Kember <mkember@google.com>
Date: Fri May 31 18:50:16 2024

[fuchsia.input.report] Add legacy=true

This adds legacy=true on fuchsia.input.report declarations removed in
API level 20, because they still exist in supported API levels
(currently the oldest supported level is 15).

These elements were removed in I9d1bc216599135e8f6470de22b2e634e27fafd59
without legacy=true.

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: I6ffb6f0baf747ed9e081e8d6671ac565f6f7c1ff
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1056928
API-Review: Mukesh Agrawal <quiche@google.com>
Reviewed-by: Mukesh Agrawal <quiche@google.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
Commit-Queue: Mitchell Kember <mkember@google.com>

M sdk/fidl/fuchsia.input.report/descriptor.fidl
M sdk/fidl/fuchsia.input.report/fuchsia.input.report.api

https://fuchsia-review.googlesource.com/1056928

ap...@google.com <ap...@google.com> #33May 31, 2024 07:01PM

Project: fuchsia
Branch: main

commit 2c74dc4ff04b57f6e483b0e6ff13c6777ea1782b
Author: Mitchell Kember <mkember@google.com>
Date: Fri May 31 19:00:20 2024

[fuchsia.sys2] Add legacy=true

This adds legacy=true on fuchsia.sys2 declarations removed in API level
19, because they still exist in supported API levels (currently the
oldest supported level is 15).

These elements were removed in I30317032d68f2184c1d77ce791060a33280d9401
without legacy=true.

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: I15218dcaaf12a2562f894739135b21331d1e7e3b
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1057556
API-Review: Gary Bressler <geb@google.com>
Reviewed-by: Gary Bressler <geb@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>

M sdk/fidl/fuchsia.sys2/fuchsia.sys2.api
M sdk/fidl/fuchsia.sys2/lifecycle_controller.fidl

https://fuchsia-review.googlesource.com/1057556

ap...@google.com <ap...@google.com> #34May 31, 2024 07:01PM

Project: fuchsia
Branch: main

commit 4c8807a526971db80bb2d606fb6ea56d522c6866
Author: Mitchell Kember <mkember@google.com>
Date: Fri May 31 18:59:39 2024

[fuchsia.component] Add legacy=true

This adds legacy=true on fuchsia.component declarations removed in API
level 20, because they still exist in supported API levels (currently
the oldest supported level is 15).

These elements were removed in I962af9d5b5973100ae4c6ee76ad00c5429f1f4f1
without legacy=true. Based on that CL, I changed some Rust code back to
using unreachable!("...") for the removed enum member.

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: I4c53757bd40d515d73ce9094dbf3c594979c41b9
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1057552
API-Review: Gary Bressler <geb@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Reviewed-by: Gary Bressler <geb@google.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>

M sdk/fidl/fuchsia.component/events.fidl
M sdk/fidl/fuchsia.component/fuchsia.component.api
M src/sys/component_manager/lib/hooks/src/

lib.rs
M src/sys/lib/component-events/src/

events.rs

https://fuchsia-review.googlesource.com/1057552

ap...@google.com <ap...@google.com> #35May 31, 2024 07:09PM

Project: fuchsia
Branch: main

commit 8a1c99d392b1cdf1da9a80018517157caca7689f
Author: Mitchell Kember <mkember@google.com>
Date: Fri May 31 19:07:18 2024

[fuchsia.hardware.audio.signalprocessing] Add legacy=true

This adds legacy=true on fuchsia.hardware.audio.signalprocessing
declarations removed in API level 20, because they still exist in
supported API levels (currently the oldest supported level is 15).

These elements were removed in the following CLs without legacy=true:

* Ibbaa8ecdf98180bef457caee55f2bdb5a67df1fd
* I5465f3b224d8b92733ea72a163045d16ba46f9a6
* I3dd529c1898eb551e5af1fd454a0a3b785f27dac

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: I37b115074faed47718a0a6a0bf962854d686c53b
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1057558
Reviewed-by: Yegor Pomortsev <ypomortsev@google.com>
Commit-Queue: Auto-Submit <auto-submit@fuchsia-infra.iam.gserviceaccount.com>
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
API-Review: Yegor Pomortsev <ypomortsev@google.com>

M sdk/fidl/fuchsia.hardware.audio.signalprocessing/dai_interconnect.fidl
M sdk/fidl/fuchsia.hardware.audio.signalprocessing/equalizer.fidl
M sdk/fidl/fuchsia.hardware.audio.signalprocessing/fuchsia.hardware.audio.signalprocessing.api
M sdk/fidl/fuchsia.hardware.audio.signalprocessing/signal_processing.fidl

https://fuchsia-review.googlesource.com/1057558

ap...@google.com <ap...@google.com> #36May 31, 2024 08:54PM

Project: fuchsia
Branch: main

commit 766c3a520ab102f239710b1413ab931f97845022
Author: Mitchell Kember <mkember@google.com>
Date: Fri May 31 20:50:32 2024

[fidlc] Validate removed/replaced ABI compatibility

This implements ABI validation for the @available removed/replaced
syntax as specified in the design document "Amendments to RFC-0232: FIDL
bindings for multiple API levels".

Members of data structures can be identified by API (name) and by ABI
(struct offset, bits/enum value, table/union/method ordinal).
Previously, fidlc only considered API in @available validation. Now, it
considers both API and ABI. This builds on the 'renamed' feature
introduced in Ibcf4dff225776a6ec604fa9a169f1aef52f36631, and it guides
the user to use removed/replaced/renamed correctly. For example:

type Foo = table {
// Before this was ok, now it's an error: ordinal 1 was removed.
@available(removed=2)
1: a string;
@available(added=2)
1: b string;

// Before this was ok, now it's an error: ordinal 2 != 3.
@available(replaced=2)
2: c string;
@available(added=2)
3: c string:10;

// Before this was ok, now it's an error: ordinal 4 != 5.
@available(replaced=2, renamed="e")
4: d string;
@available(added=2)
5: e string:10;
};

This unblocks removing LEGACY (

https://fxbug.dev/42085274) because in
order to remove LEGACY we have to be able to express all replacements
with 'replaced'. Today removed/replaced is essentially documentation,
but with multiple API levels, we will only "add back" removed elements,
not replaced elements.

Test: fx test fidlc-test
Fixed: 335716034
Bug: 42085274
Change-Id: Ic83aff64be65513dce0180fac58075318f318430
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1045473
Reviewed-by: Ian McKellar <ianloic@google.com>
Reviewed-by: Hunter Freyer <hjfreyer@google.com>
API-Review: Ian McKellar <ianloic@google.com>
Reviewed-by: Christopher Anderson <cja@google.com>
Commit-Queue: Mitchell Kember <mkember@google.com>
API-Review: Hunter Freyer <hjfreyer@google.com>

M docs/error/_redirects.yaml
M docs/reference/fidl/language/errcat.md
A docs/reference/fidl/language/error-catalog/_fi-0216.md
A docs/reference/fidl/language/error-catalog/_fi-0217.md
M docs/reference/fidl/language/error-catalog/_files.txt
M sdk/fidl/fuchsia.hardware.audio.signalprocessing/dynamics.fidl
M sdk/fidl/fuchsia.lowpan.device/device.fidl
M sdk/fidl/fuchsia.sysmem/collection.fidl
M sdk/fidl/fuchsia.sysmem/fuchsia.sysmem.api
M sdk/history/15/fuchsia.sysmem.api_summary.json
M sdk/history/16/fuchsia.sysmem.api_summary.json
M sdk/history/17/fuchsia.sysmem.api_summary.json
M sdk/history/18/fuchsia.sysmem.api_summary.json
M sdk/history/19/fuchsia.sysmem.api_summary.json
M sdk/history/20/fuchsia.sysmem.api_summary.json
M src/devices/sysmem/drivers/sysmem/buffer_collection.cc
M src/devices/sysmem/drivers/sysmem/buffer_collection.h
M src/devices/sysmem/drivers/sysmem/buffer_collection_token.cc
M src/devices/sysmem/drivers/sysmem/buffer_collection_token.h
M src/devices/sysmem/drivers/sysmem/combined_token.fidl
M tools/fidl/abi-compat/src/compare/

types_tests.rs
M tools/fidl/fidlc/src/compile_step.cc
M tools/fidl/fidlc/src/compiler.cc
M tools/fidl/fidlc/src/diagnostic_types.cc
M tools/fidl/fidlc/src/diagnostic_types.h
M tools/fidl/fidlc/src/diagnostics.h
M tools/fidl/fidlc/src/flat_ast.cc
M tools/fidl/fidlc/src/flat_ast.h
M tools/fidl/fidlc/src/properties.h
M tools/fidl/fidlc/src/replacement_step.cc
M tools/fidl/fidlc/tests/errcat_good_tests.cc
A tools/fidl/fidlc/tests/fidl/bad/fi-0216.test.fidl
A tools/fidl/fidlc/tests/fidl/bad/fi-0217.test.fidl
M tools/fidl/fidlc/tests/fidl/bad/files.txt
A tools/fidl/fidlc/tests/fidl/good/fi-0216-a.test.fidl
A tools/fidl/fidlc/tests/fidl/good/fi-0216-b.test.fidl
A tools/fidl/fidlc/tests/fidl/good/fi-0217-a.test.fidl
A tools/fidl/fidlc/tests/fidl/good/fi-0217-b.test.fidl
A tools/fidl/fidlc/tests/fidl/good/fi-0217-c.test.fidl
M tools/fidl/fidlc/tests/fidl/good/files.txt
M tools/fidl/fidlc/tests/versioning_decomposition_tests.cc
M tools/fidl/fidlc/tests/versioning_replacement_tests.cc

https://fuchsia-review.googlesource.com/1045473

ap...@google.com <ap...@google.com> #37May 31, 2024 11:01PM

Project: fuchsia
Branch: main

commit effee907cc698cfe51e0352850897f53f444e45d
Author: Mitchell Kember <mkember@google.com>
Date: Fri May 31 22:59:05 2024

[fuchsia.element] Add legacy=true

This adds legacy=true on fuchsia.element declarations removed in API
level 19, because they still exist in supported API levels (currently
the oldest supported level is 15).

These elements were removed in I70e791b4b562621650a34d579bc2289dce35f588
without legacy=true.

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: I3f428faf70d141b30b179673f300cde43da1a9d7
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1057554
Reviewed-by: Yegor Pomortsev <ypomortsev@google.com>
Commit-Queue: Mitchell Kember <mkember@google.com>
API-Review: Yegor Pomortsev <ypomortsev@google.com>

M sdk/fidl/fuchsia.element/element_manager.fidl
M sdk/fidl/fuchsia.element/fuchsia.element.api

https://fuchsia-review.googlesource.com/1057554

ap...@google.com <ap...@google.com> #38Jun 3, 2024 08:36PM

Project: fuchsia
Branch: main

commit f9cbae3c622d4afb51b1e649dfa3aafa10a025cd
Author: Mitchell Kember <mkember@google.com>
Date: Mon Jun 03 20:34:15 2024

[fuchsia.hardware.audio] Add legacy=true

This adds legacy=true on fuchsia.hardware.audio declarations removed in
API level 20, because they still exist in supported API levels
(currently the oldest supported level is 15).

These elements were removed in the following CLs without legacy=true:

1. Ib8b01bd650cac30bcc46a37bc3d7adec06f000c5
2. I3e2560c40dde70f82b5476103035e0cbfa62e599

I reverted parts of (2) to continue handling the removed methods. Once
they are no longer in any supported API level, code for handling the
methods can be removed.

The motivation for this is to line up legacy=true with the current set
of supported API levels for the implementation of RFC-0232.

Bug: 42085274
Change-Id: If10de08a8ae9ba7b47faee24a902f2a377a660f5
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1056927
Commit-Queue: Mitchell Kember <mkember@google.com>
Reviewed-by: Andres Oportus <andresoportus@google.com>
API-Review: Bruno Dal Bo <brunodalbo@google.com>
API-Review: Marie Janssen <jamuraa@google.com>
Reviewed-by: Marie Janssen <jamuraa@google.com>

M sdk/fidl/fuchsia.hardware.audio/codec.fidl
M sdk/fidl/fuchsia.hardware.audio/fuchsia.hardware.audio.api
M sdk/fidl/fuchsia.hardware.audio/ring_buffer.fidl
M src/connectivity/bluetooth/lib/fuchsia-audio-device/src/

codec.rs
M src/devices/power/drivers/nelson-brownout-protection/nelson-brownout-protection-test.cc
M src/media/audio/drivers/aml-g12-tdm/test/stream-test.cc
M src/media/audio/drivers/codecs/da7219/da7219-server.cc
M src/media/audio/drivers/codecs/da7219/da7219-server.h
M src/media/audio/drivers/configurator/src/

default.rs
M src/media/audio/drivers/testing/realm/test-codec.cc
M src/media/audio/drivers/testing/realm/test-codec2.cc
M src/media/audio/drivers/virtual_audio/virtual_audio_codec.cc
M src/media/audio/drivers/virtual_audio/virtual_audio_codec.h
M src/media/audio/lib/simple-codec/include/lib/simple-codec/simple-codec-client.h
M src/media/audio/lib/simple-codec/include/lib/simple-codec/simple-codec-server-internal.h
M src/media/audio/lib/simple-codec/include/lib/simple-codec/simple-codec-server.h
M src/media/audio/lib/simple-codec/simple-codec-client.cc
M src/media/audio/lib/simple-codec/simple-codec-server.cc
M src/media/audio/lib/simple-codec/tests/test.cc
M src/media/audio/services/device_registry/testing/fake_codec.h

https://fuchsia-review.googlesource.com/1056927

ap...@google.com <ap...@google.com> #39Jun 7, 2024 03:50AM

Project: fuchsia
Branch: main

commit 8ed18b3687f49263aa996d907b1ada6a3d2030ab
Author: David Dorwin <ddorwin@google.com>
Date: Fri Jun 07 03:44:04 2024

[versioning] Add runtime_supported_api_levels GN variable

Add platform_version.runtime_supported_api_levels, which is the runtime
equivalent of platform_version.build_time_supported_api_levels.

Also add handling of sunset and special in-development API levels as
these are supported at runtime.

Bug: 323889271, 326277078, 42085274
Test: ./build/config/fuchsia/get_platform_version.py --version-history-path sdk/version_history.json
Change-Id: Icfc4103c21dbee7a5a9af0d75c274b57e168e62d
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1060374
Reviewed-by: Hunter Freyer <hjfreyer@google.com>
Commit-Queue: David Dorwin <ddorwin@google.com>

M build/config/fuchsia/get_platform_version.py

https://fuchsia-review.googlesource.com/1060374

ap...@google.com <ap...@google.com> #40Jun 7, 2024 06:34PM

Project: fuchsia
Branch: main

commit 348c348a678ec05dc54b69c20bc903b8163bd5b4
Author: Mitchell Kember <mkember@google.com>
Date: Fri Jun 07 18:30:45 2024

[fidlc] Implement RFC-0232 multiple version selection

This CL implements "RFC-0232: FIDL bindings for multiple API levels" in
fidlc, and changes the GN build from using `--available fuchsia:LEGACY`
to using `--available fuchsia:15,16,17,18,19,20,NEXT,HEAD`. The list of
supported API levels is derived from //sdk/version_history.json.

FIDL files still have `legacy=true` attributes, but fidlc now reports an
error if a `legacy` attribute is inconsistent with the set of supported
API levels. A follow-up change will remove the `legacy` argument.

There is one limitation: when targeting 2+ versions, the set of versions
must include HEAD. This limitation is implicit in how LEGACY works, and
keeping it makes the transition easier. It will be lifted in the future.

Test: fx test fidlc-test
Bug: 42085274
Change-Id: I79c264efdc4ae1cbb545f7be6862180a4cfbffb4
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/955053
Reviewed-by: Ian McKellar <ianloic@google.com>
Reviewed-by: Hunter Freyer <hjfreyer@google.com>
Commit-Queue: Mitchell Kember <mkember@google.com>
API-Review: Ian McKellar <ianloic@google.com>

M build/config/fuchsia/target_api_level.gni
M build/fidl/fidl_ir.gni
M build/fidl/fidl_library.gni
M sdk/banjo/fuchsia.sysmem/constraints.fidl
M tools/fidl/abi-compat/src/

convert.rs
M tools/fidl/abi-compat/src/

ir.rs
M tools/fidl/fidlc/cmd/fidlc/main.cc
M tools/fidl/fidlc/goldens/aliases.json.golden
M tools/fidl/fidlc/goldens/anonymous.json.golden
M tools/fidl/fidlc/goldens/arrays.json.golden
M tools/fidl/fidlc/goldens/bindings_denylist.json.golden
M tools/fidl/fidlc/goldens/bits.json.golden
M tools/fidl/fidlc/goldens/bits_constants.json.golden
M tools/fidl/fidlc/goldens/byte_and_bytes.json.golden
M tools/fidl/fidlc/goldens/constants.json.golden
M tools/fidl/fidlc/goldens/consts.json.golden
M tools/fidl/fidlc/goldens/doc_comments.json.golden
M tools/fidl/fidlc/goldens/driver_handle.json.golden
M tools/fidl/fidlc/goldens/driver_one_way.json.golden
M tools/fidl/fidlc/goldens/driver_service.json.golden
M tools/fidl/fidlc/goldens/driver_two_way.json.golden
M tools/fidl/fidlc/goldens/empty_struct.json.golden
M tools/fidl/fidlc/goldens/encapsulated_structs.json.golden
M tools/fidl/fidlc/goldens/enum.json.golden
M tools/fidl/fidlc/goldens/error.json.golden
M tools/fidl/fidlc/goldens/error_syntax.json.golden
M tools/fidl/fidlc/goldens/escaping.json.golden
M tools/fidl/fidlc/goldens/experimental_maybe_from_alias.json.golden
M tools/fidl/fidlc/goldens/experimental_zx_c_types.json.golden
M tools/fidl/fidlc/goldens/foreign_type_in_response_used_through_compose.json.golden
M tools/fidl/fidlc/goldens/handles.json.golden
M tools/fidl/fidlc/goldens/handles_in_types.json.golden
M tools/fidl/fidlc/goldens/imported_const_values.json.golden
M tools/fidl/fidlc/goldens/inheritance.json.golden
M tools/fidl/fidlc/goldens/inheritance_with_recursive_decl.json.golden
M tools/fidl/fidlc/goldens/new_type.json.golden
M tools/fidl/fidlc/goldens/nullable.json.golden
M tools/fidl/fidlc/goldens/overlay.json.golden
M tools/fidl/fidlc/goldens/padding.json.golden
M tools/fidl/fidlc/goldens/placement_of_attributes.json.golden
M tools/fidl/fidlc/goldens/protocol_layouts.json.golden
M tools/fidl/fidlc/goldens/protocol_layouts_same_library.json.golden
M tools/fidl/fidlc/goldens/protocol_payloads.json.golden
M tools/fidl/fidlc/goldens/protocol_request.json.golden
M tools/fidl/fidlc/goldens/protocols.json.golden
M tools/fidl/fidlc/goldens/request_flexible_envelope.json.golden
M tools/fidl/fidlc/goldens/service.json.golden
M tools/fidl/fidlc/goldens/string_arrays.json.golden
M tools/fidl/fidlc/goldens/struct.json.golden
M tools/fidl/fidlc/goldens/struct_default_value_enum_library_reference.json.golden
M tools/fidl/fidlc/goldens/table.json.golden
M tools/fidl/fidlc/goldens/transitive_dependencies.json.golden
M tools/fidl/fidlc/goldens/transitive_dependencies_compose.json.golden
M tools/fidl/fidlc/goldens/types_in_protocols.json.golden
M tools/fidl/fidlc/goldens/union.json.golden
M tools/fidl/fidlc/goldens/union_sandwich.json.golden
M tools/fidl/fidlc/goldens/unknown_interactions.json.golden
M tools/fidl/fidlc/goldens/vectors.json.golden
M tools/fidl/fidlc/goldens/versions.json.golden
M tools/fidl/fidlc/schema.json
M tools/fidl/fidlc/src/availability_step.cc
M tools/fidl/fidlc/src/diagnostics.h
M tools/fidl/fidlc/src/json_generator.cc
M tools/fidl/fidlc/src/json_generator.h
M tools/fidl/fidlc/src/json_writer.h
M tools/fidl/fidlc/src/versioning_types.cc
M tools/fidl/fidlc/src/versioning_types.h
M tools/fidl/fidlc/tests/test_library.h
M tools/fidl/lib/fidlgen/types.go

https://fuchsia-review.googlesource.com/955053

ap...@google.com <ap...@google.com> #41Jun 11, 2024 05:45PM

Project: fuchsia
Branch: main

commit 23720ffa9b7e2c309995352cd68609e7bdb7f951
Author: Mitchell Kember <mkember@google.com>
Date: Tue Jun 11 17:40:46 2024

[fidl] Remove @available legacy argument

This removes the @available argument 'legacy' from all .fidl files, and
removes support from it in fidlc, since it is obsoleted by RFC-0232
(targeting multiple API levels). Some background:

* Before, FIDL authors used @available(removed=N, legacy=true) to
implement APIs in the platform at the special API level LEGACY.

* Since I79c264efdc4ae1cbb545f7be6862180a4cfbffb4, fidlc has enforced
legacy=true and legacy=false based on the set of supported API levels
passed to it, e.g. `--available fuchsia:15,16,17,18,19,20,21,HEAD`.

* With this CL, fidlc no longer allows 'legacy' arguments in .fidl
source, and infers them instead.

Internally, fidlc still refers to the combined set of target API levels
as LEGACY, because it is still modeled as HEAD + re-adding things that
were removed. A follow up will remove that restriction and all remnants
of the "legacy" idea, completing the transition to the RFC-0232 model.

Test: fx test fidlc-test
Bug: 42085274
Change-Id: I98b72daf091e57e4ea5b0d447d4708a8440ba4d6
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1062057
Fuchsia-Auto-Submit: Mitchell Kember <mkember@google.com>
API-Review: Ian McKellar <ianloic@google.com>
Reviewed-by: Ian McKellar <ianloic@google.com>
Reviewed-by: John Bauman <jbauman@google.com>
Commit-Queue: Mitchell Kember <mkember@google.com>

M docs/reference/fidl/language/error-catalog/_fi-0182.md
M docs/reference/fidl/language/error-catalog/_fi-0183.md
M examples/fidl/fuchsia.examples.docs/versioning.test.fidl
M sdk/banjo/fuchsia.sysmem/constraints.fidl
M sdk/fidl/fuchsia.component/events.fidl
M sdk/fidl/fuchsia.diagnostics/log_settings.fidl
M sdk/fidl/fuchsia.driver.framework/topology.fidl
M sdk/fidl/fuchsia.driver.test/realm.fidl
M sdk/fidl/fuchsia.element/element_manager.fidl
M sdk/fidl/fuchsia.gpu.magma/magma.fidl
M sdk/fidl/fuchsia.hardware.audio.signalprocessing/dai_interconnect.fidl
M sdk/fidl/fuchsia.hardware.audio.signalprocessing/equalizer.fidl
M sdk/fidl/fuchsia.hardware.audio.signalprocessing/signal_processing.fidl
M sdk/fidl/fuchsia.hardware.audio/codec.fidl
M sdk/fidl/fuchsia.hardware.audio/ring_buffer.fidl
M sdk/fidl/fuchsia.hardware.radar/radar.fidl
M sdk/fidl/fuchsia.images2/math.fidl
M sdk/fidl/fuchsia.input.report/descriptor.fidl
M sdk/fidl/fuchsia.lightsensor/calibrator.fidl
M sdk/fidl/fuchsia.lightsensor/types.fidl
M sdk/fidl/fuchsia.mediastreams/compression.fidl
M sdk/fidl/fuchsia.mediastreams/media_format.fidl
M sdk/fidl/fuchsia.mediastreams/video_format.fidl
M sdk/fidl/fuchsia.settings/display.fidl
M sdk/fidl/fuchsia.sys2/lifecycle_controller.fidl
M sdk/fidl/fuchsia.sysmem/collection.fidl
M sdk/fidl/fuchsia.sysmem/constraints.fidl
M sdk/fidl/fuchsia.sysmem/driver_connector.fidl
M sdk/fidl/fuchsia.ui.gfx/commands.fidl
M sdk/fidl/fuchsia.ui.gfx/events.fidl
M sdk/fidl/fuchsia.ui.gfx/nodes.fidl
M sdk/fidl/fuchsia.ui.gfx/renderer.fidl
M sdk/fidl/fuchsia.ui.gfx/resources.fidl
M sdk/fidl/fuchsia.ui.gfx/shapes.fidl
M sdk/fidl/fuchsia.ui.gfx/tokens.fidl
M sdk/fidl/fuchsia.ui.gfx/types.fidl
M sdk/fidl/fuchsia.ui.scenic/overview.fidl
M tools/fidl/fidlc/src/attribute_schema.cc
M tools/fidl/fidlc/src/availability_step.cc
M tools/fidl/fidlc/src/availability_step.h
M tools/fidl/fidlc/src/diagnostics.h
M tools/fidl/fidlc/src/versioning_types.cc
M tools/fidl/fidlc/src/versioning_types.h
M tools/fidl/fidlc/tests/errcat_good_tests.cc
D tools/fidl/fidlc/tests/fidl/bad/fi-0182.test.fidl
D tools/fidl/fidlc/tests/fidl/bad/fi-0183.test.fidl
M tools/fidl/fidlc/tests/fidl/bad/files.txt
D tools/fidl/fidlc/tests/fidl/good/fi-0182-a.test.fidl
D tools/fidl/fidlc/tests/fidl/good/fi-0182-b.test.fidl
D tools/fidl/fidlc/tests/fidl/good/fi-0183-a.test.fidl
D tools/fidl/fidlc/tests/fidl/good/fi-0183-b.test.fidl
M tools/fidl/fidlc/tests/fidl/good/files.txt
M tools/fidl/fidlc/tests/test_library.cc
M tools/fidl/fidlc/tests/test_library.h
M tools/fidl/fidlc/tests/versioning_attribute_tests.cc
M tools/fidl/fidlc/tests/versioning_basic_tests.cc
M tools/fidl/fidlc/tests/versioning_decomposition_tests.cc
M tools/fidl/fidlc/tests/versioning_inheritance_tests.cc
M tools/fidl/fidlc/tests/versioning_interleaving_tests.cc
M tools/fidl/fidlc/tests/versioning_overlap_tests.cc
M tools/fidl/fidlc/tests/versioning_types_tests.cc

https://fuchsia-review.googlesource.com/1062057

ap...@google.com <ap...@google.com> #42Jun 18, 2024 02:37AM

Project: fuchsia
Branch: main

commit f1d270a4da877a199b123bb0fc59ad52d19186f7
Author: Mitchell Kember <mkember@google.com>
Date: Tue Jun 18 02:33:04 2024

[docs][fidl] Update documentation for RFC-0232

This updates FIDL documentation for "RFC-0232: FIDL bindings for
multiple API levels". Specifically:

* Document the 'renamed' argument, implemented in
Ibcf4dff225776a6ec604fa9a169f1aef52f36631.

* Document ABI identity checks, implemented in
Ic83aff64be65513dce0180fac58075318f318430.

* Document targeting sets of multiple versions, implemented in
I79c264efdc4ae1cbb545f7be6862180a4cfbffb4.

* Remove mentions of the LEGACY version and 'legacy' argument, gone
since I98b72daf091e57e4ea5b0d447d4708a8440ba4d6.

Bug: 42085274
Change-Id: Ia3492a45426cae117099cd1d9ed8578bb84ac6f8
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1064815
Reviewed-by: Ian McKellar <ianloic@google.com>
Reviewed-by: David Dorwin <ddorwin@google.com>
Commit-Queue: Mitchell Kember <mkember@google.com>

M docs/development/api/evolution.md
M docs/reference/fidl/language/attributes.md
M docs/reference/fidl/language/error-catalog/_fi-0201.md
M docs/reference/fidl/language/versioning.md
M examples/fidl/fuchsia.examples.docs/versioning.test.fidl

https://fuchsia-review.googlesource.com/1064815

is...@google.com <is...@google.com> Sep 12, 2024 07:59AM

Status: New