FTP-041: Support for Unifying Services and Devices [42160684]

Epic

Status Update

No update yet.

Description

pa...@google.com

created issue #1

Jun 26, 2019 06:32PM

Migrated from

https://fuchsia.atlassian.net/browse/FIDL-713

## Overview of Implementation Plan

* Source compatibility rules: FIDL team
* Language changes + JSON IR: FIDL team
* Example service in C++: CF team
* Determine what is going to be
* 1\. Codegened
* 2\. FIDL owned runtime
* 3\. CF owned runtime
* Translation of example into other languages (Dart, Rust, Go, etc.)
* Codegen for HLCPP based on example: CF team (in collaboration with respective bindings authors)
* Codegen for other bindings
* Each bindings owner following example in C++, and translation of example
* Documentation
* Grammar, Language spec: FIDL team
* FTP -> md: FIDL team
* FIDL rubric & best practices: CF team
* Echo example : CF team
* 4 flavors of services
* Editor support: FIDL team to inform various editor owners of changes

[Discoverable] to `service`

* Transition to be owned by CF post implementation
* (FIDL team can assist as needed)

## See also

* [FTP-041](

https://fuchsia.googlesource.com/fuchsia/+/master/docs/development/languages/fidl/reference/ftp/ftp-041.md)
* [FIDL services and build systems](

https://docs.google.com/document/d/1asHHQ8MbnwDJGTloDYxSx8MIGQPJ_89YuMk8aQkM3sg/edit)
* [Exposing Unified Services](

https://docs.google.com/document/d/1KWYVzj3NGjDp3miNNyMRFpEOWBWpxNXy3OT_3TBaqHo/edit)

Comments

pa...@google.com <pa...@google.com> #2Jun 29, 2019 06:46AM

[Mandatory Source Compatibility for Service
Declarations](

https://docs.google.com/document/d/1i_f3PXO4pkhsyDUdyrvOnaCH-
pkwXURp1naP1xbnC_k/edit) approved. It needs to be amended to `ftp-041.md` and
added to `bindings.md`, I’ll do a CL for that.

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #3Aug 12, 2019 07:02AM

[Empty comment from Monorail migration]

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #4Aug 12, 2019 07:25AM

[Empty comment from Monorail migration]

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #5Aug 12, 2019 07:25AM

[Empty comment from Monorail migration]

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #6Aug 12, 2019 07:26AM

[Empty comment from Monorail migration]

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #7Aug 12, 2019 07:26AM

[Empty comment from Monorail migration]

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #8Aug 12, 2019 07:26AM

[Empty comment from Monorail migration]

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #9Aug 12, 2019 07:26AM

[Empty comment from Monorail migration]

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #10Aug 12, 2019 07:26AM

[Empty comment from Monorail migration]

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #11Aug 12, 2019 10:14AM

[Empty comment from Monorail migration]

ap...@google.com <ap...@google.com> #12Aug 23, 2019 10:34PM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #13Jun 1, 2021 11:31PM

Marked as fixed.

[Empty comment from Monorail migration]

pa...@google.com <pa...@google.com> #14Jun 1, 2021 11:36PM

Status: In Progress (Accepted) (reopened)

Is it done? I think we are missing quite a lot:

* Dart support
* Rust support
* Bindings spec
* Documentation for each of the bindings
* Adding this to the compatibility test
* Likely various other things :)

pa...@google.com <pa...@google.com> #15Jun 1, 2021 11:36PM

s/Rust support/Go support/ in

#comment13

ab...@google.com <ab...@google.com> #16Jun 2, 2021 10:25AM

Ack, fair point. :)

Adam, you had some documentation that you were holding off from landing. Would you be happy to land it now?

ad...@google.com <ad...@google.com> #17Jun 2, 2021 10:31PM

I think we can land documentation once

https://fuchsia-review.googlesource.com/c/fuchsia/+/521887 lands, since that change will alter what the API looks like from the client's perspective.

ab...@google.com <ab...@google.com> #18Jun 3, 2021 09:38AM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #19Jun 3, 2021 09:38AM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #20Jun 3, 2021 09:40AM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #21Jun 3, 2021 09:42AM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #22Jun 3, 2021 09:44AM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #23Jun 3, 2021 09:45AM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #24Jun 3, 2021 09:51AM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #25Jun 3, 2021 09:57AM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #26Jun 3, 2021 09:58AM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #27Jun 3, 2021 10:00AM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #28Jun 3, 2021 10:22AM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #29Jun 3, 2021 10:24AM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #30Jun 3, 2021 10:29AM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #31Jun 3, 2021 10:30AM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #32Jun 3, 2021 10:31AM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #33Jun 3, 2021 10:32AM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #34Jun 3, 2021 10:36AM

[Empty comment from Monorail migration]

ab...@google.com <ab...@google.com> #35Jun 3, 2021 10:51AM

For (my own) reference, here is the FIDL project checklist:

https://fuchsia.dev/fuchsia-src/contribute/contributing-to-fidl/fidl-project-checklist

yp...@google.com <yp...@google.com> #36Jul 19, 2021 11:19PM

[Empty comment from Monorail migration]

mk...@google.com <mk...@google.com> #37Feb 9, 2022 10:41PM

This feature has been in limbo for a long time. I'm writing down the timeline here so that I can link here in the future.

* In April 2019, [RFC-0041: Support for unifying services and devices](

https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0041_unifying_services_devices?hl=en) was accepted.
* It was implemented in FIDL bindings for C++ and Rust, but not Go nor Dart.
* In June 2021, there was an email thread "Completing FTP-041: Support for Unifying Services and Devices":
* Pascal judged the feature to be ~40% done, and identified the following remaining tasks: spec updates, support in all bindings (fidlgen backends and runtime support), testing (gidl/conformance suite, dynamic compatibility tests, dangerous identifiers, source_compatibility), docs (example code, guides, bindings reference, FIDL API rubric).
* The CF team filed [bugs for each task](

https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=label%3Aunified-services&can=1) with the "unified-services" label.
* The CF team wanted support for hierarchical instance names, e.g. `/svc/fuchsia.example.MyService/instance_name1/instance_name2/protocol_name`.
* Pascal suggested this change to the design (and others) deserved its own RFC.
* Adam Lesinski wrote [RFC: Amendment to RFC-0041 to support collection-backed services](

https://fuchsia-review.googlesource.com/c/fuchsia/+/544164/).
* After some discussion, this was withdrawn.
* In November 2021, Adam commented that they are not pursuing this design at this time.

As of today (February 2022):

* It is still not implemented in Go/Dart.
* `@discoverable` is used 500+ times in non-test .fidl files in fuchsia.git.

sh...@google.com <sh...@google.com> #38Apr 14, 2023 03:25AM

[Empty comment from Monorail migration]

is...@google.com <is...@google.com> #39Apr 14, 2023 03:25AM

This issue was migrated from

crbug.com/fuchsia/8035?no_tracker_redirect=1

[Monorail blocked-on:

crbug.com/fuchsia/4776,

crbug.com/fuchsia/77933,

crbug.com/fuchsia/77934,

crbug.com/fuchsia/77935,

crbug.com/fuchsia/77936,

crbug.com/fuchsia/77937,

crbug.com/fuchsia/77938,

crbug.com/fuchsia/77939,

crbug.com/fuchsia/77940,

crbug.com/fuchsia/77941,

crbug.com/fuchsia/77942,

crbug.com/fuchsia/77943,

crbug.com/fuchsia/77944,

crbug.com/fuchsia/77945,

crbug.com/fuchsia/77946,

crbug.com/fuchsia/77947,

crbug.com/fuchsia/77948,

crbug.com/fuchsia/8072,

crbug.com/fuchsia/8073,

crbug.com/fuchsia/8074,

crbug.com/fuchsia/8094,

crbug.com/fuchsia/8095,

crbug.com/fuchsia/8096,

crbug.com/fuchsia/8097]
[Monorail blocking:

crbug.com/fuchsia/33183]
[Monorail components added to Monorail Components custom field.]

mk...@google.com <mk...@google.com> #40Jan 12, 2024 06:40PM

Status: New

Discussion in team sync: we should chat with CF team about what we want to do with this.

Issue 42160684

Description

Issue summary

Comments

pa...@google.com <pa...@google.com> #2Jun 29, 2019 06:46AM

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #3Aug 12, 2019 07:02AM

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #4Aug 12, 2019 07:25AM

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #5Aug 12, 2019 07:25AM

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #6Aug 12, 2019 07:26AM

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #7Aug 12, 2019 07:26AM

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #8Aug 12, 2019 07:26AM

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #9Aug 12, 2019 07:26AM

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #10Aug 12, 2019 07:26AM

fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com <fu...@fuchsia-monorail.google.com.iam.gserviceaccount.com> #11Aug 12, 2019 10:14AM

ap...@google.com <ap...@google.com> #12Aug 23, 2019 10:34PM

ab...@google.com <ab...@google.com> #13Jun 1, 2021 11:31PM

pa...@google.com <pa...@google.com> #14Jun 1, 2021 11:36PM

pa...@google.com <pa...@google.com> #15Jun 1, 2021 11:36PM

ab...@google.com <ab...@google.com> #16Jun 2, 2021 10:25AM

ad...@google.com <ad...@google.com> #17Jun 2, 2021 10:31PM

ab...@google.com <ab...@google.com> #18Jun 3, 2021 09:38AM

ab...@google.com <ab...@google.com> #19Jun 3, 2021 09:38AM

ab...@google.com <ab...@google.com> #20Jun 3, 2021 09:40AM

ab...@google.com <ab...@google.com> #21Jun 3, 2021 09:42AM

ab...@google.com <ab...@google.com> #22Jun 3, 2021 09:44AM

ab...@google.com <ab...@google.com> #23Jun 3, 2021 09:45AM

ab...@google.com <ab...@google.com> #24Jun 3, 2021 09:51AM

ab...@google.com <ab...@google.com> #25Jun 3, 2021 09:57AM

ab...@google.com <ab...@google.com> #26Jun 3, 2021 09:58AM

ab...@google.com <ab...@google.com> #27Jun 3, 2021 10:00AM

ab...@google.com <ab...@google.com> #28Jun 3, 2021 10:22AM

ab...@google.com <ab...@google.com> #29Jun 3, 2021 10:24AM

ab...@google.com <ab...@google.com> #30Jun 3, 2021 10:29AM

ab...@google.com <ab...@google.com> #31Jun 3, 2021 10:30AM

ab...@google.com <ab...@google.com> #32Jun 3, 2021 10:31AM

ab...@google.com <ab...@google.com> #33Jun 3, 2021 10:32AM

ab...@google.com <ab...@google.com> #34Jun 3, 2021 10:36AM

ab...@google.com <ab...@google.com> #35Jun 3, 2021 10:51AM

yp...@google.com <yp...@google.com> #36Jul 19, 2021 11:19PM

mk...@google.com <mk...@google.com> #37Feb 9, 2022 10:41PM

sh...@google.com <sh...@google.com> #38Apr 14, 2023 03:25AM

is...@google.com <is...@google.com> #39Apr 14, 2023 03:25AM

mk...@google.com <mk...@google.com> #40Jan 12, 2024 06:40PM

Add comment

Issue metadata