Fuchsia

RFC for the nonce option defined in https://www.rfc-editor.org/rfc/rfc3971#section-5.3.2

This issue was migrated from crbug.com/fuchsia/131009?no_tracker_redirect=1

[Auto-CCs applied]
[Monorail components added to Monorail Components custom field.]

Project: fuchsia
Branch: main

commit 3774c320a7231a93fa36191e47fd536305811c70
Author: Evan Wildenhain <wildenhain@google.com>
Date:   Fri Jun 21 17:14:16 2024

    [network/tests] Test DAD success after echoed NS
   
    Tests that duplicate address detection succeeds even if the netstack's
    neighbor solicitation is echoed back to it.
   
    This currently passes on netstack2 and (expectedly) fails on netstack3
    due to lack of support for the NDP nonce option.
   
    Bug: 42081267
    Change-Id: I715ca81ad2f556eb22cf4fbfe9cf15391aa9246d
    Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1069133
    Reviewed-by: Bruno Dal Bo <brunodalbo@google.com>
    Commit-Queue: Evan Wildenhain <wildenhain@google.com>

M       src/connectivity/network/tests/integration/common/src/ndp.rs
M       src/connectivity/network/tests/integration/expects/netstack-ipv6-integration-test.json5
M       src/connectivity/network/tests/integration/ipv6/src/lib.rs
M       src/connectivity/network/tests/integration/socket/src/lib.rs

https://fuchsia-review.googlesource.com/1069133

Project: fuchsia
Branch: main

commit 5add0b1cbeef8429206f58bd31c87a36d4d3e07d
Author: Evan Wildenhain <wildenhain@google.com>
Date:   Thu Jul 11 23:41:49 2024

    [netstack3] Use Nonce NDP option in DAD
   
    Uses the Nonce NDP option (per RFC 7527) to avoid failing
    duplicate-address-detection when our neighbor solicitations are looped
    back to us.
   
    Adds a counter for dropping incoming neighbor solicitations when they
    are judged to be looped-back DAD probes.
   
    Test: netstack3-core-ip-test
    Multiply: ipv6-integration
    Fixed: 42081267
    Change-Id: Ia3762094e0d50f22989c2ba6e436d3fa2e2368f5
    Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1071772
    Reviewed-by: Bruno Dal Bo <brunodalbo@google.com>
    Commit-Queue: Evan Wildenhain <wildenhain@google.com>
    Reviewed-by: Jeff Martin <martinjeffrey@google.com>

M       src/connectivity/lib/packet-formats/src/icmp/ndp.rs
M       src/connectivity/network/netstack3/core/ip/BUILD.gn
M       src/connectivity/network/netstack3/core/ip/src/base.rs
M       src/connectivity/network/netstack3/core/ip/src/device.rs
M       src/connectivity/network/netstack3/core/ip/src/device/dad.rs
M       src/connectivity/network/netstack3/core/ip/src/device/nud.rs
M       src/connectivity/network/netstack3/core/ip/src/device/state.rs
M       src/connectivity/network/netstack3/core/ip/src/icmp.rs
M       src/connectivity/network/netstack3/core/ip/tests/src/device/base.rs
M       src/connectivity/network/netstack3/core/ip/tests/src/device/ndp.rs
M       src/connectivity/network/netstack3/core/src/ip/device.rs
M       src/connectivity/network/netstack3/core/src/testutil.rs
M       src/connectivity/network/tests/integration/common/src/ndp.rs
M       src/connectivity/network/tests/integration/expects/netstack-ipv6-integration-test.json5
M       src/connectivity/network/tests/integration/inspect/src/ns3.rs
M       src/connectivity/network/tests/integration/ipv6/src/lib.rs

https://fuchsia-review.googlesource.com/1071772

[Details redacted due to bug visibility]

Change-Id: If564ce0026be91702ca4f233534def5796803481
https://turquoise-internal-review.googlesource.com/860971