Trace importing crashes. [328124336]

Fixed

Bug

Status Update

No update yet.

Description

gm...@google.com

created issue #1

Mar 4, 2024 11:25PM

trace_importer.py can assert with the below error. Likely the durations are incorrectly nested. We should add better recovery support for when then happens since dropping a Duration Begin event should be allowed.

[GeneratedLocalTestbed] 02-29 11:56:04.638 ERROR Exception occurred in test_launch_hermetic_test.
Traceback (most recent call last):
  File "out/default/host_x64/obj/src/tests/end_to_end/suspend/power_suspend_test_fc_test/power_suspend_test_fc_test.pyz/mobly/base_test.py", line 783, in exec_one_test
    test_method()
  File "out/default/host_x64/obj/src/tests/end_to_end/suspend/power_suspend_test_fc_test/power_suspend_test_fc_test.pyz/suspend_test.py", line 54, in test_launch_hermetic_test
    model: trace_model.Model = trace_importing.create_model_from_file_path(
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "out/default/host_x64/obj/src/tests/end_to_end/suspend/power_suspend_test_fc_test/power_suspend_test_fc_test.pyz/trace_processing/trace_importing.py", line 237, in create_model_from_file_path
    return create_model_from_file(file)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "out/default/host_x64/obj/src/tests/end_to_end/suspend/power_suspend_test_fc_test/power_suspend_test_fc_test.pyz/trace_processing/trace_importing.py", line 250, in create_model_from_file
    return create_model_from_json(json.load(file))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "out/default/host_x64/obj/src/tests/end_to_end/suspend/power_suspend_test_fc_test/power_suspend_test_fc_test.pyz/trace_processing/trace_importing.py", line 451, in create_model_from_json
    assert duration_stack

Comments

gm...@google.com <gm...@google.com> Mar 4, 2024 11:25PM

Accepted by gm...@google.com.

ap...@google.com <ap...@google.com> #2Mar 6, 2024 04:37PM

Marked as fixed.

Project: fuchsia
Branch: main

commit 81f89fe2f8e39e56a8d09a3cf98ad52dc8a4220c
Author: Gwen Mittertreiner <gmtr@google.com>
Date: Wed Mar 06 16:36:35 2024

[trace_importer] Recover from Badly Nested Durations

Durations are expected to nest nicely, but sometimes traces can have
incorrectly nested durations. While the trace is corrupted here, the
rest of the trace is likely still fine so, we should attempt some form
of recovery.

Fixed: 328124336
Change-Id: I87ac0a66377a91436af2214ff4c22eef0abb6ac3
Reviewed-on:

https://fuchsia-review.googlesource.com/c/fuchsia/+/1001403
Reviewed-by: Krithika Balan <krithikabalan@google.com>
Commit-Queue: Gwen Mittertreiner <gmtr@google.com>

M src/performance/lib/trace_processing/tests/data/model.json
M src/performance/lib/trace_processing/tests/trace_importing_test.py
M src/performance/lib/trace_processing/trace_importing.py

https://fuchsia-review.googlesource.com/1001403

Issue 328124336

Description

Issue summary

Comments

gm...@google.com <gm...@google.com> Mar 4, 2024 11:25PM

ap...@google.com <ap...@google.com> #2Mar 6, 2024 04:37PM

Add comment

Issue metadata